Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify hash of Python installer #21877

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chocobo1
Copy link
Member

No description provided.

@Chocobo1 Chocobo1 added the Search engine Issues related to the search engine/search plugins functionality label Nov 19, 2024
@Chocobo1 Chocobo1 added this to the 5.1 milestone Nov 19, 2024
Copy link
Member

@glassez glassez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would extract the code into separate function bool verifyPythonInstaller(const Path &installerPath).

src/gui/mainwindow.cpp Outdated Show resolved Hide resolved
src/gui/mainwindow.cpp Outdated Show resolved Hide resolved
@Chocobo1
Copy link
Member Author

I would extract the code into separate function bool verifyPythonInstaller(const Path &installerPath).

Done.

@Chocobo1 Chocobo1 requested a review from a team November 19, 2024 13:14
@thalieht thalieht added the OS: Windows Issues specific to Windows label Nov 19, 2024
const QString PYTHON_INSTALLER_URL = u"https://www.python.org/ftp/python/3.13.0/python-3.13.0-amd64.exe"_s;
const QByteArray PYTHON_INSTALLER_MD5 = QByteArrayLiteral("f5e5d48ba86586d4bef67bcb3790d339");
const QByteArray PYTHON_INSTALLER_SHA3_512 = QByteArrayLiteral("28ed23b82451efa5ec87e5dd18d7dacb9bc4d0a3643047091e5a687439f7e03a1c6e60ec64ee1210a0acaf2e5012504ff342ff27e5db108db05407e62aeff2f1");
Copy link
Member Author

@Chocobo1 Chocobo1 Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavier2k6
In the future, in case you want to update python installer, you can use this site to calculate SHA3-512 hash: https://emn178.github.io/online-tools/sha3_512_checksum.html
The MD5 hash should be copied from python.org as is: https://www.python.org/downloads/release/python-3130/

@xavier2k6
Copy link
Member

@Chocobo1 Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: Windows Issues specific to Windows Search engine Issues related to the search engine/search plugins functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants