Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Darker colors for dark theme #21498

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/webui/www/private/css/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@
--color-text-blue: hsl(210deg 88.1% 73.5%);
--color-text-orange: hsl(26deg 65% 70%);
--color-text-default: hsl(0deg 0% 90%);
--color-background-blue: hsl(210deg 42% 48%);
--color-background-blue: hsl(210deg 42% 30%);
--color-background-popup: hsl(0deg 0% 20%);
--color-background-default: hsl(0deg 0% 25%);
--color-background-hover: hsl(26deg 50% 55%);
--color-background-default: hsl(0deg 0% 12%);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally i like the other 2 changes but this one makes "Alternating row colors" practically useless.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my screens (sRGB) the difference between rows is visible, I also tried also with 15% lightness value (instead of 12%) and it's still ok for me, but any value above 15% it starts to hurt my eyes. As it is now (25% L) is almost unusable for me, and the fact I cannot switch back to the light theme easily it worsen the problem

--color-background-hover: hsl(26deg 80% 20%);
--color-border-default: hsl(0deg 0% 33%);

color-scheme: dark;
Expand Down
Loading