Search: Lax separator matching when filtering results #21370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any separator will now match any other separator when filtering search results. Example: Type "live server" in filter. Currently it would only match "live server". Consequently, if you type "live.server" it will only match "live.server" and not "live server" even though the user likely wants to see both. With this update any separator now matches any other separator; A space now matches `.` `-` `_`, an underscore also matches a space and a dash, etcetera. This means that a filter of "live server" will now show "live.server" in the results. This is a lot more intuitive in my opinion.
ducalex
force-pushed
the
ducalex/ignore-search-filter-separator
branch
from
80131ee
to
08dae5f
Compare
thalieht
added
Search engine
|
IMO, if such behavior is acceptable to be approved, it at least should be optional (someone may not like it). |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates search result filtering behavior to be more intuitive.
Any separator (
_-.) will now match any other separator when filtering search results.Example: Type "live server" in filter. Currently it would only match "live server". Similarly, if you type "live.server" it will only match "live.server" and not "live server" even though the user likely wants to see both.
With this update any separator now matches any other separator; a space now matches
.-_, an underscore also matches a space or a dash, etc.This means that a filter of "live server" will now show "live.server" in the results and vice-versa.
Note that this does not affect regex search, only regular wildcard search.
This is a lot more intuitive in my opinion!