Use class modifiers to detect primitive classes #184

dmlloyd · 2022-04-21T17:19:43Z

No description provided.

dgrove-oss · 2022-04-21T18:58:34Z

java.base/src/main/java/java/lang/Class$_patch.java

@@ -202,6 +202,11 @@ public Class<?> getNestHost() {
        return nestHost;
    }

+    @Replace
+    public boolean isPrimitive() {
+        return (modifiers & (1 << 17)) != 0;


Would be nice if we could use I_ACC_PRIMITIVE here instead of hardcoding 17.

dmlloyd · 2022-05-04T16:17:55Z

The tests are failing because it appears we have multiple class objects for each given primitive type.

dgrove-oss approved these changes Apr 21, 2022

View reviewed changes

dgrove-oss reviewed Apr 21, 2022

View reviewed changes

dmlloyd force-pushed the prim branch from 60184bf to 0965a48 Compare April 22, 2022 18:49

Use class modifiers to detect primitive classes

e3cf553

dmlloyd force-pushed the prim branch from 0965a48 to e3cf553 Compare December 6, 2022 15:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use class modifiers to detect primitive classes #184

Use class modifiers to detect primitive classes #184

dmlloyd commented Apr 21, 2022

dgrove-oss Apr 21, 2022

dmlloyd commented May 4, 2022

Use class modifiers to detect primitive classes #184

Are you sure you want to change the base?

Use class modifiers to detect primitive classes #184

Conversation

dmlloyd commented Apr 21, 2022

dgrove-oss Apr 21, 2022

Choose a reason for hiding this comment

dmlloyd commented May 4, 2022