Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 - Bumped versions to 2.4 for next release #248

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Jul 19, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@WackerO WackerO changed the title Bumped versions to 2.4 for next release 4 - Bumped versions to 2.4 for next release Jul 19, 2024
Copy link

github-actions bot commented Jul 19, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5d143bb

+| ✅ 171 tests passed       |+
#| ❔  17 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 2.4
  • readme - README did not have a Nextflow minimum version badge.
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-22 11:44:26

Copy link
Collaborator

@skrakau skrakau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WackerO WackerO merged commit 73a712a into qbic-pipelines:dev Jul 22, 2024
16 checks passed
@WackerO WackerO deleted the versions_2_4 branch July 22, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants