Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Reinstate Flutter's "deprecated member" lint warning #619

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

brenodt
Copy link
Collaborator

@brenodt brenodt commented Apr 8, 2024

Description

The goal here is to revert this patch PR: #572

At the time it was done, the flame_forge2d package was not up-to-date with flame, which had deprecated the camera component.

The workaround was to disable the "deprecated member" lint warning (link).

Since then, flame_forge2d was updated, and we now can upgrade it and safely move to the new camera system.

This PR reinstates the lint rule and fixes all deprecated members that have appeared in the codebase, besides refactoring the Network tab to use the new Flame/Forge2D camera logic.

@brenodt brenodt requested a review from MathJud April 8, 2024 20:41
@brenodt brenodt self-assigned this Apr 8, 2024
@MathJud MathJud merged commit 95409c1 into main Apr 9, 2024
8 checks passed
@MathJud MathJud deleted the chore/reinstate-fe-deprecated-linting-rule branch April 9, 2024 03:34
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants