Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networked varys #120

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Add networked varys #120

wants to merge 7 commits into from

Conversation

qaisjp
Copy link
Owner

@qaisjp qaisjp commented Apr 6, 2021

To fix now:

  • In-memory seems to be a little bit buggy and crashes occasionally, seemingly due to a bug in the memconn library (should we just use a unix socket?)

    If we do end up just using a unix socket, in-memory should automatically create a temporary socket somewhere.

To fix in a future PR:

  • Haven't tested reconnections, and haven't written any new logic here. Likely to not work properly. (I think it sends Quit commands to each puppet too...)
  • Ok so now I've turned off Quit on varys client disconnect. Now I need to add data sync when connecting, right now it just reconnects. (Maybe I should make connects just a nop instead...?)

@qaisjp
Copy link
Owner Author

qaisjp commented Apr 16, 2021

ten days ago, i cut my small test server over to this branch implementation (using memconn, and not a separate server), and they haven't crashed yet!

@qaisjp
Copy link
Owner Author

qaisjp commented Apr 17, 2021

Okay, running a test now with separated client/server varys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant