Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use specific safety schema version #618

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use specific safety schema version #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ install_requires =
rich
typer
pydantic>=1.10.12
safety_schemas>=0.0.4
safety_schemas==0.0.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider using ~= instead of == for version constraint.

While pinning to an exact version ensures stability, using ~=0.0.5 would allow patch updates while preventing minor version changes. This provides a balance between stability and security updates.

-    safety_schemas==0.0.5
+    safety_schemas~=0.0.5
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
safety_schemas==0.0.5
safety_schemas~=0.0.5

typing-extensions>=4.7.1
filelock~=3.12.2
psutil~=6.0.0
Expand Down
2 changes: 1 addition & 1 deletion test_requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Authlib>=1.2.0
rich
typer
pydantic>=1.10.12
safety_schemas>=0.0.4
safety_schemas==0.0.5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider the trade-offs of strict version pinning.

While pinning to ==0.0.5 ensures reproducible environments, it might cause you to miss important updates. Consider using ~=0.0.5 (compatible release) to automatically accept patch updates while maintaining stability.

-safety_schemas==0.0.5
+safety_schemas~=0.0.5
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
safety_schemas==0.0.5
safety_schemas~=0.0.5

typing-extensions>=4.7.1
filelock~=3.12.2
psutil~=6.0.0
Loading