Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ABI L2 "CPS" variable name for Cloud Particle Size #2995

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

yufeizhu600
Copy link
Contributor

@yufeizhu600 yufeizhu600 commented Nov 21, 2024

NOAA has changed the variable name of cloud particle size from PSD to CPS in the GOES-R ABI l2 OR_ABI-L2-CPS* product files since 18:51UTC December 04, 2023.
source: GOES-16 and GOES-18 Software Build PR.13.01.00 Implementation

Dec04, 2023
Update 4: Due to the ongoing anomaly causing an outage of all GOES-16 and GOES-18 ABI products going to PDA, a change in product generation strings has taken place. This change caused the PR.13.01.00 build to go live immediately upon the switch, or around 1851 UTC this afternoon rather than tomorrow at the previously listed times.

Update data variable name in Cloud Particle Size product - Up to now, the Cloud Particle Size product produced by the Cloud Optical and Microphysical Properties (COMP) algorithm, has incorrectly listed its primary variable as “Particle Size Distribution” (PSD). This is being updated in this release to properly refer to the product as “Cloud Particle Size” (CPS), which will also make it consistent with its output filename (i.e. OR_ABI-L2-CPS*).

From NOAA's GOES-R open data on AWS, the first product files with new variable name are:
GOES-16 Meso1 :
OR_ABI-L2-CPSM1-M6_G16_s20233381851251_e20233381851308_c20233381852188.nc
GOES-16 Meso2 :
OR_ABI-L2-CPSM2-M6_G16_s20233381851551_e20233381852007_c20233381852465.nc
GOES-16 CONUS :
OR_ABI-L2-CPSC-M6_G16_s20233381851172_e20233381853545_c20233381857105.nc
GOES-16 FULLDISK :
OR_ABI-L2-CPSF-M6_G16_s20233381900205_e20233381909513_c20233381915549.nc

GOES-18 Meso1 :
OR_ABI-L2-CPSM1-M6_G18_s20233381852260_e20233381852317_c20233381853212.nc
GOES-18 Meso2 :
OR_ABI-L2-CPSM2-M6_G18_s20233381851560_e20233381852017_c20233381853198.nc
GOES-18 PACUS :
OR_ABI-L2-CPSC-M6_G18_s20233381856181_e20233381858554_c20233381901548.nc
GOES-18 FULLDISK :
OR_ABI-L2-CPSF-M6_G16_s20233381900205_e20233381909513_c20233381915549.nc

This PR add the new variable name CPS into the config file of abi_l2_nc reader, so that it can read CPS variable from OR_ABI-L2-CPS* L2 product files.
Configuration fro PSD variable has not been changed to ensure backward compatibility.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (fa56be5) to head (80c93cb).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2995   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         377      377           
  Lines       55155    55155           
=======================================
  Hits        52997    52997           
  Misses       2158     2158           
Flag Coverage Δ
behaviourtests 3.94% <ø> (ø)
unittests 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 11978998402

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.193%

Totals Coverage Status
Change from base Build 11936881763: 0.0%
Covered Lines: 53241
Relevant Lines: 55348

💛 - Coveralls

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe add a comment mentioning the name change and the date it took effect?

@yufeizhu600
Copy link
Contributor Author

Could you maybe add a comment mentioning the name change and the date it took effect?

Sure, I have updated the description above to include the time of change from NOAA's bulletin. And also added the first product file of each satellite scan section after the switch.

@djhoese
Copy link
Member

djhoese commented Nov 22, 2024

Sorry I meant in the YAML right above the new definition maybe?

@yufeizhu600
Copy link
Contributor Author

Sorry I meant in the YAML right above the new definition maybe?

OK, done.

@djhoese djhoese changed the title add the new variable name of cloud particle size of GOES-R L2 CPS product into the abi l2 reader config Add new ABI L2 "CPS" variable name for Cloud Particle Size Nov 22, 2024
@djhoese djhoese merged commit 399aba5 into pytroll:main Nov 22, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants