Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pylint complaints for GLD360-reader. #2992

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

sjoro
Copy link
Collaborator

@sjoro sjoro commented Nov 21, 2024

This PR fixes some Pylint complaints for GLD360-reader and cleans-up the code. The PR contains no added features and/or major changes in the reader.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (fa56be5) to head (7230cfb).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2992   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files         377      377           
  Lines       55155    55157    +2     
=======================================
+ Hits        52997    52999    +2     
  Misses       2158     2158           
Flag Coverage Δ
behaviourtests 3.94% <0.00%> (-0.01%) ⬇️
unittests 96.18% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@coveralls
Copy link

coveralls commented Nov 21, 2024

Pull Request Test Coverage Report for Build 11951083562

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.193%

Totals Coverage Status
Change from base Build 11936881763: 0.0%
Covered Lines: 53243
Relevant Lines: 55350

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants