Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dummy PR for testing image comparison tests — do not merge #2987

Closed
wants to merge 1 commit into from
Closed

dummy PR for testing image comparison tests — do not merge #2987

wants to merge 1 commit into from

Conversation

gerritholl
Copy link
Member

This is a dummy dummy PR to test image comparison tests.

DO NOT MERGE

@gerritholl
dummy commit DO NOT MERGE
92f76ef 
This is a dummy commit for a dummy branch for a dummy PR to test image comparison tests.

DO NOT MERGE
@gerritholl gerritholl changed the title dummy commit DO NOT MERGE dummy PR for testing image comparison tests — do not merge Nov 20, 2024
gerritholl
gerritholl commented Nov 20, 2024
View reviewed changes
Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

gerritholl
gerritholl commented Nov 20, 2024
View reviewed changes
Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

gerritholl
gerritholl commented Nov 20, 2024
View reviewed changes
Copy link
Member Author

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start behave test

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11930890463

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.193%
Totals Coverage Status
Change from base Build 11930864601: 0.0%
Covered Lines: 53234
Relevant Lines: 55341
💛 - Coveralls

@gerritholl
Copy link
Member Author

I thought the image comparison bot was failing to clone branches on forks, but it actually succeeds, despite the error message fatal: Remote branch enable-nwcsaf-other-geo not found in upstream origin in the log. But for this PR based on a branch on the main satpy fork, which we don't normally do, it fails to verify the Webhook signature. I'm going to ignore that as the nominal case works.

@gerritholl gerritholl closed this Nov 20, 2024
@mraspaud mraspaud deleted the dummy-branch-image-comparison-test branch November 20, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhoese djhoese Awaiting requested review from djhoese djhoese will be requested when the pull request is marked ready for review djhoese is a code owner

@mraspaud mraspaud Awaiting requested review from mraspaud mraspaud will be requested when the pull request is marked ready for review mraspaud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerritholl @coveralls