Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dtype promotion in SEVIRI native reader #2983

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

pkhalaj
Copy link
Contributor

@pkhalaj pkhalaj commented Nov 19, 2024

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.08%. Comparing base (fd2cec6) to head (da84875).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2983      +/-   ##
==========================================
- Coverage   96.10%   96.08%   -0.02%     
==========================================
  Files         377      377              
  Lines       55147    55150       +3     
==========================================
- Hits        52997    52992       -5     
- Misses       2150     2158       +8     
Flag Coverage Δ
behaviourtests 3.94% <0.00%> (-0.01%) ⬇️
unittests 96.18% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@pkhalaj pkhalaj marked this pull request as ready for review November 19, 2024 22:23
@coveralls
Copy link

coveralls commented Nov 19, 2024

Pull Request Test Coverage Report for Build 11929321333

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 96.193%

Files with Coverage Reduction New Missed Lines %
satpy/tests/utils.py 2 93.16%
satpy/tests/reader_tests/gms/test_gms5_vissr_l1b.py 3 98.67%
satpy/tests/reader_tests/gms/test_gms5_vissr_navigation.py 3 97.18%
Totals Coverage Status
Change from base Build 11815057382: -0.01%
Covered Lines: 53236
Relevant Lines: 55343

💛 - Coveralls

@pnuu pnuu changed the title Fix bug #2981 Fix dtype promotion in SEVIRI native reader Nov 20, 2024
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the simple fix! Just one suggestion in-line. And I changed the topic so that the actual issue is shown. The topics are used in the changelog, so "Fix bug #2981" wouldn't tell much :-)

@pkhalaj
Copy link
Contributor Author

pkhalaj commented Nov 20, 2024

Thanks for the simple fix! Just one suggestion in-line. And I changed the topic so that the actual issue is shown. The topics are used in the changelog, so "Fix bug #2981" wouldn't tell much :-)

Thanks. I just applied your suggestion regarding type checking the computed values as well.

@pkhalaj pkhalaj requested a review from pnuu November 20, 2024 08:31
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix.

@sfinkens
Copy link
Member

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the bug with satpy when using numpy 2.x which leads to SEVIRI resampled files having a double size
5 participants