-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dtype promotion in SEVIRI native reader #2983
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2983 +/- ##
==========================================
- Coverage 96.10% 96.08% -0.02%
==========================================
Files 377 377
Lines 55147 55150 +3
==========================================
- Hits 52997 52992 -5
- Misses 2150 2158 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Pull Request Test Coverage Report for Build 11929321333Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the simple fix! Just one suggestion in-line. And I changed the topic so that the actual issue is shown. The topics are used in the changelog, so "Fix bug #2981" wouldn't tell much :-)
Co-authored-by: Panu Lahtinen <[email protected]>
Thanks. I just applied your suggestion regarding type checking the computed values as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the fix.
Nice, thanks! |
satpy
when usingnumpy 2.x
which leads toSEVIRI
resampled files having a double size #2981AUTHORS.md
if not there already