Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dtype promotion in SunZenithReduction #2950

Merged
merged 4 commits into from
Nov 8, 2024

Use log-magic to simplify code

6193040
Select commit
Loading
Failed to load commit list.
Merged

Fix dtype promotion in SunZenithReduction #2950

Use log-magic to simplify code
6193040
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Nov 4, 2024 in 45s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.16 (9.37 -> 9.21)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication test_modifiers.py

Annotations

Check warning on line 217 in satpy/tests/test_modifiers.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Code Duplication 

introduced similar code in: TestSunZenithReducer.test_custom_settings,TestSunZenithReducer.test_default_settings. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
View more details on CodeScene Delta Analysis