Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more platforms to VIIRS EDR reader #2949

Merged
merged 7 commits into from
Oct 23, 2024

Conversation

joleenf
Copy link
Contributor

@joleenf joleenf commented Oct 23, 2024

Add additional key/value pairs to the platform_name dictionary in the viirs_edr.py reader.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (9c1075c) to head (a4b8c8d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2949   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         377      377           
  Lines       55074    55074           
=======================================
  Hits        52924    52924           
  Misses       2150     2150           
Flag Coverage Δ
behaviourtests 3.94% <ø> (ø)
unittests 96.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joleenf joleenf closed this Oct 23, 2024
@coveralls
Copy link

coveralls commented Oct 23, 2024

Pull Request Test Coverage Report for Build 11484404930

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.202%

Totals Coverage Status
Change from base Build 11478294616: 0.0%
Covered Lines: 53168
Relevant Lines: 55267

💛 - Coveralls

@joleenf joleenf reopened this Oct 23, 2024
@joleenf
Copy link
Contributor Author

joleenf commented Oct 23, 2024

I am ready with this pull request now. I added a test to cover a new expected shortname.

@djhoese djhoese merged commit 798e753 into pytroll:main Oct 23, 2024
19 of 20 checks passed
@djhoese djhoese changed the title Update dict viirs edr Add more platforms to VIIRS EDR reader Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Missing" platform abbreviation causes unexpected error when loading data array in Scene
3 participants