Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests using palettize #2944

Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Oct 21, 2024

After merging pytroll/trollimage#179 and pytroll/trollimage#181 and creating a new Trollimage release, two tests using palettize and water_detection (also does palettize) were failing because of the added _FillValue attribute. The fix gets a bit ugly because colorize also passes palettes but doesn't add the _FillValue attribute.

  • Tests added

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.09%. Comparing base (d62b5d2) to head (b9a2f4d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2944      +/-   ##
==========================================
- Coverage   96.11%   96.09%   -0.03%     
==========================================
  Files         377      377              
  Lines       55067    55070       +3     
==========================================
- Hits        52929    52920       -9     
- Misses       2138     2150      +12     
Flag Coverage Δ
behaviourtests 3.94% <0.00%> (-0.01%) ⬇️
unittests 96.19% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11437490447

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.202%

Totals Coverage Status
Change from base Build 11403042925: 0.0%
Covered Lines: 53164
Relevant Lines: 55263

💛 - Coveralls

@pnuu pnuu requested a review from gerritholl October 21, 2024 10:06
Copy link
Member

@gerritholl gerritholl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mraspaud mraspaud merged commit 9b4f1f4 into pytroll:main Oct 21, 2024
17 of 18 checks passed
@pnuu pnuu deleted the fix-palettize-adding-fill-value-attribute branch October 21, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants