-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OCI L2 BGC reader #2902
Add OCI L2 BGC reader #2902
Conversation
FYI @kathys, I will also need to update Polar2Grid's resampling configuration if we want OCI to be EWA resampled. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2902 +/- ##
=======================================
Coverage 96.06% 96.07%
=======================================
Files 370 371 +1
Lines 54320 54361 +41
=======================================
+ Hits 52185 52226 +41
Misses 2135 2135
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 10850896247Details
💛 - Coveralls |
The OCI instrument does not seem to have multiple rows per scans and is therefore not suitable for EWA resampling (not really at least). That also means a "rows_per_scan" metadata value can be set to 0 just fine. |
Shouldn't it be 1 then? |
Although not well documented (or at all), rows_per_scan being 1 would mean each row is a scan. It being 0 is more of a "treat the entire swath as a scan". The usage is primarily by the EWA resampling, so while I agree 1 is logical, 0 also doesn't cause much harm...at least in my opinion. |
I'm good with that. Would you mind just dropping a line about this in the documentation if not already there? |
Maybe in the reader metadata documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We have a user who wants to be able to read OCI L2 Chlorophyll data from "biogeochemical" files (BGC). These are generally standardized to match the existing SEADAS L2 files that we (Polar2Grid) already supported so this new reader uses that reader for all its python functionality.
TODO: If there is a "rows per scan" similar to VIIRS or MODIS then I need to update the python code to use that.
Related ssec/polar2grid#708
CC @kathys