Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance support for FY-3F/MERSI-3 #2861

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MengXin001
Copy link

@MengXin001 MengXin001 commented Jul 26, 2024

This PR enhanced support for FY-3F/MERSI-3 data. Includes fixed geolocation dataset name in 250m data, support get coefficients, etc.
Actually, I'm not sure whether the test config is correct. theoretically, this test is basically the same as the FY-3D.

  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@mraspaud mraspaud requested a review from simonrp84 July 26, 2024 07:20
@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Jul 26, 2024
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this reader! In principle this looks good to me. However I would like someone who knows more about this format to have a look, maybe @simonrp84 ?

@MengXin001
Copy link
Author

I read the official document incorrectly, the part of geolocation data was originally correct, so I reverted the corresponding changes. The remaining enhancement to get coefficients is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants