-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] add small example to flight recorder tutorial #3163
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3163
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4e7692a with merge base 540bd0c (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
2794049
to
846b766
Compare
dfbd8c0
to
0c7de76
Compare
Summary: Add a small example that demonstrated flight recorder end-to-end. Test Plan: Test on github to make sure that the tutorial renders correctly.
0c7de76
to
0052a44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of min
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the publishing perspective this should be okay. Can @fduwjj do a technical review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for adding that.
Summary:
Add a small example that demonstrates flight recorder end-to-end.
Test Plan:
Test on github to make sure that the tutorial renders correctly.
Description
Add an example to demonstrates flight recorder by using a small program that induces a crash.
Checklist