Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DeprecationWarning #1528

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix DeprecationWarning #1528

wants to merge 1 commit into from

Conversation

jcaip
Copy link
Contributor

@jcaip jcaip commented Jan 8, 2025

quick fix for #1522

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1528

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit 69cb271 with merge base eb49333 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2025
@jcaip jcaip requested review from vkuzo and drisspg January 8, 2025 05:22
@jcaip jcaip mentioned this pull request Jan 8, 2025
Open
drisspg
drisspg reviewed Jan 8, 2025
View reviewed changes
torchao/float8/float8_linear.py
@@ -309,7 +309,7 @@ def cast_input_to_float8(self, input: torch.Tensor) -> torch.Tensor:
if torch.is_autocast_enabled():
# For now, hardcode to GPU's autocast dtype
# if we need CPU support in the future, we can add it
autocast_dtype = torch.get_autocast_gpu_dtype()
autocast_dtype = torch.get_autocast_gpu_dtype('cuda')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input.device?
just in case lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

@vkuzo vkuzo Awaiting requested review from vkuzo

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcaip @drisspg @facebook-github-bot