Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate new differentiable fp8 conversion funcs into Float8NoCompileLinear #1496

Merged
merged 23 commits into from
Jan 8, 2025
Merged

integrate new differentiable fp8 conversion funcs into Float8NoCompileLinear #1496

merged 23 commits into from
Jan 8, 2025
+75 −50

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Jan 3, 2025 •
edited
Loading

No description provided.

@danielvegamyhre
Update
f85618f 
[ghstack-poisoned]
@danielvegamyhre
Update
c603139 
[ghstack-poisoned]
@danielvegamyhre
Update
9b42e69 
[ghstack-poisoned]
@danielvegamyhre
Update
fc301fd 
[ghstack-poisoned]
@danielvegamyhre
Update
a69fc66 
[ghstack-poisoned]
@danielvegamyhre
Update
1d2ee55 
[ghstack-poisoned]
@danielvegamyhre
Copy link
Contributor Author

danielvegamyhre commented Jan 3, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1496

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 49373f1 with merge base d42a382 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jan 3, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jan 3, 2025
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025
@danielvegamyhre danielvegamyhre requested a review from vkuzo January 3, 2025 21:52
danielvegamyhre added a commit to danielvegamyhre/ao that referenced this pull request Jan 6, 2025
@danielvegamyhre
integrate new differentiable fp8 conversion funcs into Float8NoCompil…
44560e3 
…eLinear

ghstack-source-id: 8f945be34787c3a15fa886826c8261bc1116539c
ghstack-comment-id: 2569853141
Pull Request resolved: pytorch#1496
@danielvegamyhre danielvegamyhre mentioned this pull request Jan 7, 2025
Merged
vkuzo
vkuzo reviewed Jan 7, 2025
View reviewed changes
torchao/prototype/float8nocompile/float8nocompile_linear.py Outdated
return grad_input, grad_weight, None, None, None


class matmul_with_args_in_fp8(torch.autograd.Function):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@danielvegamyhre
Update
2bbdf88 
[ghstack-poisoned]
@danielvegamyhre
Update
58be437 
[ghstack-poisoned]
@danielvegamyhre
Update
25298cb 
[ghstack-poisoned]
@danielvegamyhre
Update
89c6b53 
[ghstack-poisoned]
@danielvegamyhre
Update
0808acf 
[ghstack-poisoned]
@danielvegamyhre
Update
ddf1efc 
[ghstack-poisoned]
@danielvegamyhre
Update
0536cb8 
[ghstack-poisoned]
@danielvegamyhre
Update
10830d8 
[ghstack-poisoned]
@danielvegamyhre
Update
5a47687 
[ghstack-poisoned]
@danielvegamyhre danielvegamyhre mentioned this pull request Jan 7, 2025
Merged
@danielvegamyhre
Update
a6becf8 
[ghstack-poisoned]
@danielvegamyhre
Update
5714e99 
[ghstack-poisoned]
@danielvegamyhre
Update
7ccdd26 
[ghstack-poisoned]
@danielvegamyhre
Update
23266fb 
[ghstack-poisoned]
@danielvegamyhre
Update
99fab5a 
[ghstack-poisoned]
@danielvegamyhre danielvegamyhre mentioned this pull request Jan 7, 2025
Open
@danielvegamyhre
Update
4aadedf 
[ghstack-poisoned]
@danielvegamyhre danielvegamyhre changed the base branch from gh/danielvegamyhre/13/head to main January 8, 2025 00:11
@danielvegamyhre danielvegamyhre mentioned this pull request Jan 8, 2025
Open
@danielvegamyhre
Update
e11918d 
[ghstack-poisoned]
@danielvegamyhre
Update
49373f1 
[ghstack-poisoned]
@danielvegamyhre danielvegamyhre mentioned this pull request Jan 8, 2025
Closed
@danielvegamyhre danielvegamyhre merged commit eb49333 into main Jan 8, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkuzo vkuzo vkuzo approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielvegamyhre @vkuzo @facebook-github-bot