-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cleanup][2/x] split float8 mm by delayed vs dynamic #1461
Open
vkuzo
wants to merge
3
commits into
gh/vkuzo/13/head
Choose a base branch
from
gh/vkuzo/14/head
base: gh/vkuzo/13/head
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1461
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c9f3a3f with merge base 457c5b1 (): NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Dec 27, 2024
vkuzo
added a commit
that referenced
this pull request
Dec 27, 2024
Summary: Before this PR, the float8 mm logic was split by axiswise vs tensorwise. After this PR, the float8 mm logic is split by dynamic vs non-dynamic scaling. Motivation: there is more and more evidence that dynamic scaling will be common to the most important lowp recipes. This PR is a step on the way to making the dynamic scaling logic be simpler and easier to understand in `torchao.float8`. There are a lot of other simplifications to do, but stopping here to keep the PR small. This is a pure refactor without any logic changes. Test Plan: ``` ./test/float8/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 8a9792272e3aeea12d705eb5a466b9830dac6420 ghstack-comment-id: 2564049757 Pull Request resolved: #1461
vkuzo
added
the
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
label
Dec 27, 2024
vkuzo
added a commit
that referenced
this pull request
Dec 27, 2024
Summary: Before this PR, the float8 mm logic was split by axiswise vs tensorwise. After this PR, the float8 mm logic is split by dynamic vs non-dynamic scaling. Motivation: there is more and more evidence that dynamic scaling will be common to the most important lowp recipes. This PR is a step on the way to making the dynamic scaling logic be simpler and easier to understand in `torchao.float8`. There are a lot of other simplifications to do, but stopping here to keep the PR small. This is a pure refactor without any logic changes. Test Plan: ``` ./test/float8/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 90b042fc76549c88a46abf06945ad166ea403e5c ghstack-comment-id: 2564049757 Pull Request resolved: #1461
This was referenced Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Before this PR, the float8 mm logic was split by axiswise vs tensorwise.
After this PR, the float8 mm logic is split by dynamic vs non-dynamic scaling.
Motivation: there is more and more evidence that dynamic scaling will
be common to the most important lowp recipes. This PR is a step on the way
to making the dynamic scaling logic be simpler and easier to understand
in
torchao.float8
.There are a lot of other simplifications to do, but stopping here to
keep the PR small. This is a pure refactor without any logic changes.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: