Add gemlite kernel option to autoquant #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att Test Plan: python generate.py --checkpoint_path $CHECKPOINT_PATH/$MODEL_REPO/model.pth --compile --compile_prefill --quantization autoquant-gemlite-int4 --output_json_path result.json Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1449
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dacec8b with merge base 1beb6d0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
added
the
topic: not user facing
mobicham
reviewed
Dec 20, 2024
| @@ -46,15 +46,14 @@ def get_gemlite_quant_kwargs(bit_width, group_size): | |||
| return kwargs | |||
|
|
|||
|
|
|||
| def apply_gemlite_quant( | |||
| def get_gemlite_aqt_kwargs( | |||
| weight, | |||
| group_size=64, | |||
| bit_width=4, | |||
| packing_bitwidth=8, | |||
| contiguous=None, | |||
There was a problem hiding this comment.
this one is using packing_bitwidth=8 by default, while the other functions are using 32. Ideally this one should be using 32 too
There was a problem hiding this comment.
will change, looks like it should be OK
drisspg
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactored gemlite quant api a bit and added gemlite as an option to autoquant:
GEMLITE_INT4_AUTOQUANT_CLASS_LISTand alsoALL_AUTOQUANT_CLASS_LISTTest Plan:
python generate.py --checkpoint_path $CHECKPOINT_PATH/$MODEL_REPO/model.pth --compile --compile_prefill --precision float16 --quantization autoquant-gemlite-int4
(gemlite only works for float16)
Reviewers:
Subscribers:
Tasks:
Tags: