Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff Lint fixes (torchao/sparsity) #1249

Merged
merged 12 commits into from
Nov 12, 2024
Merged

Ruff Lint fixes (torchao/sparsity) #1249

merged 12 commits into from
Nov 12, 2024

Conversation

jainapurva
Copy link
Contributor

Adding lint fixes in torchao/sparsity

Copy link

pytorch-bot bot commented Nov 8, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1249

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e563007 with merge base b2642fb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 8, 2024
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix CI

tibidoh and others added 8 commits November 11, 2024 16:14
Differential Revision: D65570988

Pull Request resolved: #1248
Summary: trying to fix fbcode CI

Test Plan: see CI

Reviewers:

Subscribers:

Tasks:

Tags:
stack-info: PR: #1252, branch: drisspg/stack/20
* pin nightlies to deal with std::badalloc

* Update regression_test.yml
* support dcp.save

* add test for dcp.load()

* fix test

* typo

* implement aten.slice

* skip test

* fix checks

* run ruff

* fix formatting

* remove add safe globals in test

* sort some imports

---------

Co-authored-by: Mark Saroufim <[email protected]>
@jainapurva jainapurva marked this pull request as ready for review November 12, 2024 00:16
@jainapurva jainapurva added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Nov 12, 2024
@jainapurva jainapurva merged commit eaa3daa into main Nov 12, 2024
18 of 19 checks passed
sunjiweiswift pushed a commit to sunjiweiswift/ao that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants