Ruff Lint fixes (torchao/float8) #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1239
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5dc7422 with merge base 657ebbb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
drisspg
approved these changes
Nov 7, 2024
|
lg, but please dont land this until the diff train is fixed |
Differential Revision: D65570988 Pull Request resolved: #1248
Summary: trying to fix fbcode CI Test Plan: see CI Reviewers: Subscribers: Tasks: Tags:
stack-info: PR: #1252, branch: drisspg/stack/20
stack-info: PR: #1247, branch: drisspg/stack/19
* pin nightlies to deal with std::badalloc * Update regression_test.yml
* support dcp.save * add test for dcp.load() * fix test * typo * implement aten.slice * skip test * fix checks * run ruff * fix formatting * remove add safe globals in test * sort some imports --------- Co-authored-by: Mark Saroufim <[email protected]>
jainapurva
added
the
topic: not user facing
sunjiweiswift
pushed a commit
to sunjiweiswift/ao
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix linting using ruff for torchao/float8 module