metal lowbit kernels: split scales and zero points #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1202
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e4211da with merge base 75f52ae ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65232787 |
manuelcandales
added a commit
to manuelcandales/ao
that referenced
this pull request
Oct 30, 2024
Summary: Pull Request resolved: pytorch#1202 Differential Revision: D65232787
manuelcandales
force-pushed
the
export-D65232787
branch
from
1afd8c0 to
fe06a21
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65232787 |
manuelcandales
added a commit
to manuelcandales/ao
that referenced
this pull request
Oct 30, 2024
Summary: Pull Request resolved: pytorch#1202 Differential Revision: D65232787
malfet
approved these changes
Oct 31, 2024
I actually don't see any meaningful difference. The reported numbers below are averages over 100 runs each time, on an M1 Pro. The variability between obtained averages from run to run that I observe, is actually higher than the Before-After difference. Before:
After:
|
manuelcandales
force-pushed
the
export-D65232787
branch
from
fe06a21 to
240ac8f
Compare
manuelcandales
added a commit
to manuelcandales/ao
that referenced
this pull request
Nov 11, 2024
Summary: Pull Request resolved: pytorch#1202 Reviewed By: malfet Differential Revision: D65232787
|
This pull request was exported from Phabricator. Differential Revision: D65232787 |
Summary: Pull Request resolved: pytorch#1202 Reviewed By: malfet Differential Revision: D65232787
manuelcandales
force-pushed
the
export-D65232787
branch
from
240ac8f to
e4211da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65232787 |
metascroy
added
the
topic: improvement
jerryzh168
added
topic: not user facing
sunjiweiswift
pushed a commit
to sunjiweiswift/ao
that referenced
this pull request
Nov 25, 2024
Differential Revision: D65232787 Pull Request resolved: pytorch#1202
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
…tionalEmbeddings (pytorch#1202) * update rope class * remove old rope class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D65232787