Pin torch nightly - Oct 1 #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1008
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4565a88 with merge base 9ce7ebb ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
approved these changes
Oct 3, 2024
jainapurva
force-pushed
the
version_fix_torch_nightly
branch
from
84a6753 to
4565a88
Compare
msaroufim
reviewed
Oct 4, 2024
| @@ -188,6 +188,7 @@ def snr(ref, actual): | |||
| assert snr(inputs_ref.grad, inputs_int8mp.grad) > 20 | |||
| assert snr(linear.weight.grad, linear_int8mp.weight.grad) > 20 | |||
|
|
|||
| @pytest.mark.skip('Flaky on CI') | |||
There was a problem hiding this comment.
should only skip if the version of pytorch is at least 2.6, the other tests seemed green
msaroufim
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
@jainapurva gonna merge this for now to unblock others from merging code but could you please open 2 separate issues
- Assign to @gau-nernst the bitnet training skip
- Another issue on the IMA error we're seeing
melvinebenezer
pushed a commit
to melvinebenezer/ao
that referenced
this pull request
Oct 7, 2024
Pin torch nightly to Oct 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to memory leak and other additional compile issues with latest torch-nightly, pinning it to last stable version torch==2.6.0.dev20241001+cu121