Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: extend deprecation check to references #81

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ENH: extend deprecation check to references #81

wants to merge 1 commit into from

Conversation

sbrugman
Copy link
Collaborator

@sbrugman sbrugman commented Sep 23, 2024 •
edited
Loading

Example of false negatives that were previously undetected:

func = torch.my_deprecated_function
func(A, B, C)

=>

func = torch.my_new_function
func([A, B, C])

(Still needs updated test cases)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrugman @facebook-github-bot