Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of num_iter #123

Closed
wants to merge 1 commit into from
Closed

Add support of num_iter #123

wants to merge 1 commit into from

Conversation

yanbing-j
Copy link
Collaborator

This PR is to add support of num_iter, so that users can specify the iterations to run. If not set num_iter, it will run the whole epoch.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 5, 2024
cpuhrsch
cpuhrsch reviewed Jun 5, 2024
View reviewed changes
Copy link
Contributor

@cpuhrsch cpuhrsch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! The limit argument should already give you this capability. Did you try it? It might be hard to find.

@yanbing-j
Copy link
Collaborator Author

Thanks for the comments! I have tried limit, which can early stop at the specific length. I will close this PR.

@yanbing-j yanbing-j closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanbing-j @cpuhrsch @facebook-github-bot