Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix alibi bias #86

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix alibi bias #86

merged 2 commits into from
Dec 3, 2024

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Dec 2, 2024 •
edited
Loading

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 2, 2024
@kashif kashif changed the title fix alibi bas fix alibi bias Dec 2, 2024
@kashif kashif mentioned this pull request Dec 2, 2024
Open
kashif
kashif commented Dec 2, 2024
View reviewed changes
examples/flex_attn.ipynb Outdated Show resolved Hide resolved
drisspg
drisspg approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@drisspg drisspg merged commit 290c1e7 into pytorch-labs:main Dec 3, 2024
1 check passed
@kashif kashif deleted the alibi branch December 3, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It seems that visualize_attention_scores can only visualize either mask-mod-only or score-mod-only
3 participants
@kashif @drisspg @facebook-github-bot