Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It seems that visualize_attention_scores can only visualize either mask-mod-only or score-mod-only #29

Closed
XinDongol opened this issue Aug 23, 2024 · 2 comments · Fixed by #86
Closed

It seems that visualize_attention_scores can only visualize either mask-mod-only or score-mod-only #29

XinDongol opened this issue Aug 23, 2024 · 2 comments · Fixed by #86
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@XinDongol
Copy link

attention-gym/attn_gym/utils.py

Line 68 in 7586742

def visualize_attention_scores(

@drisspg
Copy link
Contributor

drisspg commented Aug 26, 2024

Do you have an example that needs both? It should deff be possible to extend it to visualize both

@drisspg drisspg added enhancement New feature or request good first issue Good for newcomers labels Aug 26, 2024
@XinDongol
Copy link
Author

XinDongol commented Aug 26, 2024 •
edited
Loading

For example, if we want to apply Alibi positional embedding/soft-cap within the sliding window, a visualize_attention_scores() that supports both will be very useful.

@kashif kashif mentioned this issue Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix alibi bias kashif/attention-gym
2 participants
@XinDongol @drisspg