Fix: Large negative increments #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep actual previous line memory instead of max in trace().
Keep max memory display, but use actual memory for increment.
|
FYI: the current implementation seems wrong: (Specifically, the calculation seems wrong starting from the line 111, included)
|
|
@nyngwang does the fix in this PR solve your problem? |
@nyngwang Is it because the values seem too large? You can divide the number in the third column by the number in the last column to get the average increment/decrement. It's actually quite small. The second column is the max increment seen. |
|
@fabianp No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #219
During loops the memory may decrease from one iteration to the next. Storing max(memory, prev_line_memory) can lead to ongoing decrements of the increment value since only the max value is stored and it is used to calculate the change to the increment. This change stores the most recent memory value instead of the max.