Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move changelog&version check to pre-commit and to a separate CI job that skips on skip-release label
Remaining quirks:
--allow-future
if it triggers onpush
.The test file is kind of ugly now in that it both looks like a pytest file and doesn't. I should probably add some comments at the very least.
EDIT: actually, I shouldn't skip the CI job with the skip-release label - I should just make that pass
--allow-future
as well.(also the flag is somewhat opaquely named, probs time to do a proper argparse solution).
It's also not great that skip-release doesn't actually skip a release attempt, afair we just rely on pushing-the-same-version-again to twine to not do anything.