Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unable to access nested list property #93

Merged
merged 14 commits into from
Jan 11, 2021
Merged

fix: Unable to access nested list property #93

merged 14 commits into from
Jan 11, 2021

Conversation

arajkumar
Copy link
Contributor

This PR fixes #91.

j5awry
j5awry previously approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@j5awry j5awry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, and for providing good testing! I've confirmed the bug. We're working on pushing 0.2.0 atm. We should pull this in for 0.3.0.

ziirish
ziirish previously approved these changes Mar 23, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Mar 25, 2020 •
edited
Loading

Codecov Report

Merging #93 (66ae18a) into master (570d5c6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   96.85%   96.86%           
=======================================
  Files          19       19           
  Lines        2705     2712    +7     
=======================================
+ Hits         2620     2627    +7     
  Misses         85       85
Impacted Files Coverage Δ
flask_restx/fields.py 96.64% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 570d5c6...66ae18a. Read the comment docs.

@arajkumar
Copy link
Contributor Author

@j5awry @ziirish
^^ ping

abunuwas
abunuwas reviewed May 12, 2020
View reviewed changes
tests/test_fields.py Outdated Show resolved Hide resolved
tests/test_fields.py Outdated Show resolved Hide resolved
@arajkumar @abunuwas
Update tests/test_fields.py
b6e13ef 
Co-authored-by: José Antonio Haro Peralta <[email protected]>
@arajkumar arajkumar dismissed stale reviews from ziirish and j5awry via b6e13ef June 1, 2020 14:45
@arajkumar arajkumar requested review from ziirish and j5awry June 1, 2020 14:45
@arajkumar
Copy link
Contributor Author

@abunuwas @j5awry @ziirish
^^ ping

@arajkumar arajkumar removed the request for review from SVilgelm June 30, 2020 13:59
@arajkumar
Copy link
Contributor Author

/ping @j5awry !

@j5awry j5awry merged commit 3614028 into python-restx:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abunuwas abunuwas abunuwas approved these changes

@j5awry j5awry j5awry approved these changes

@SteadBytes SteadBytes Awaiting requested review from SteadBytes

@ziirish ziirish Awaiting requested review from ziirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to access nested list property using dot(.) notation as specified in documentation.
4 participants
@arajkumar @ziirish @j5awry @abunuwas