fix error handler #200
Closed
fix error handler #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make sure Api does not eat exceptions which don't have error handler register Api. make it plays nicer with other extensions like Flask-JWT-Extended refs: - vimalloc/flask-jwt-extended#86 - noirbizarre/flask-restplus#340
|
Seems like Api need to be wrapped in a blueprint which has a default error handler to response to application/json |
avilaton
reviewed
Aug 17, 2020
| @@ -651,12 +651,9 @@ def handle_error(self, e): | |||
|
|
|||
| # When propagate_exceptions is set, do not return the exception to the | |||
| # client if a handler is configured for the exception. | |||
| if ( | |||
| not isinstance(e, HTTPException) | |||
| and current_app.propagate_exceptions | |||
There was a problem hiding this comment.
Why is propagate exceptions being removed here
There was a problem hiding this comment.
I want all exeptions if not handled by restx return to flask, therefore some extensions like flask-jwt-extended can work properly. I think the purpose of propagate_exceptions is for testing and debugging and if someone want to use it, they must be enduser, not library.
I see that restx's design is make the whole application for api only - by catch all exceptions and response to json, but what if i want the route /api to only handle api and the rest serves html?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure Api does not eat exceptions which don't have error handler register to Api.
make it play nicer with other extensions like Flask-JWT-Extended
refs: