Docs/docker best practices #9542
Conversation
This ensures to use the correct python executable. Using `run` simply uses `sys.prefix` with a bin suffix, which is not necessarily the currently used python executable. E.g. when linking a specific python version to a custom directory, using `sys.prefix` may point to the wrong python version: * /usr/bin/python2.7 * /usr/bin/python3.6 * /usr/bin/python is a symlink to 2.7 * /usr/bin/local/python (or any other location) is a symlink to 3.6 which shadows the former symlink `sys.prefix` is `/usr` in this case, which is correct, but the `python` executable there points to the wrong version. `run_pip` in the env fixes this already by using `sys.executable`, see https://github.com/python-poetry/poetry/blob/develop/poetry/utils/env.py#L964 This should be used in the executor as well.
radoering
force-pushed
the
docs/docker-best-practices
branch
from
d12242c
to
5500497
Compare
|
Deploy preview for website ready! ✅ Preview Built with commit 246e181. |
…idebar by the framework
…a/poetry into docs/docker-best-practices
…tall --no-root' Edit Dockerfile as suggested in - python-poetry#9542 (comment) - python-poetry#9542 (comment)
Edit Dockerfile as suggested in - python-poetry#9542 (comment)
|
I wonder if we could make a repo in our org to store those examples instead of putting them here. @radoering what do you think? |
We could. Do you propose to only put the |
Init Docker Best Practices documentation
Resolves: Discussion #1879
This PR is intended to begin the section on Docker Best Practices in Documentation.
It will serve as a collection point for all best practices (BPs) that will be recommended.
Hopefully, BPs, in order to be included and accepted here, will have to be accompanied by a concrete example that reproduces and demonstrates their effectiveness and by due references where possible.
The following contributions are proposed in this PR:
docs/docker-best-practices.md. Introduction file and list of best practices.docker-examples/. Folder with practical examples to get you started. This already comes with two examples, also referenced in the docker-best-practices.md.