-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hardcoded time units with named constants #861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Minku-Koo
commented
Nov 17, 2024
- Replaced hardcoded time-related values with named constants.
- Facilitates easier adjustments of these values and reduces potential for errors.|
- Replaced hardcoded time-related values with named constants. - Facilitates easier adjustments of these values and reduces potential for errors.|
CodSpeed Performance ReportMerging #861 will not alter performanceComparing Summary
|
- Constants declared outside the class should be directly accessed without using `self`.
@Secrus plz check it |
Fix pre-commit checks, please. |
- Ensured all files pass pre-commit checks - Fixed line length violations (E501) in `difference_formatter.py`
I fix pre-commit, but there is some problem about rust. |
Those issues are not present on the master branch, so I assume they are connected to your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.