Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hardcoded time units with named constants #861

Closed
wants to merge 6 commits into from

Conversation

Minku-Koo
Copy link
Contributor

  • Replaced hardcoded time-related values with named constants.
  • Facilitates easier adjustments of these values and reduces potential for errors.|

- Replaced hardcoded time-related values with named constants.
- Facilitates easier adjustments of these values and reduces potential for errors.|
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #861 will not alter performance

Comparing Minku-Koo:devkoo (eee1ebc) with master (a21fc8d)

Summary

✅ 1 untouched benchmarks

- Constants declared outside the class should be directly accessed without using `self`.
@Minku-Koo
Copy link
Contributor Author

@Secrus plz check it

@Secrus
Copy link
Collaborator

Secrus commented Dec 4, 2024

Fix pre-commit checks, please.

- Ensured all files pass pre-commit checks
- Fixed line length violations (E501) in `difference_formatter.py`
@Minku-Koo
Copy link
Contributor Author

I fix pre-commit, but there is some problem about rust.
In my changes, only python file is changed.

@Secrus
Copy link
Collaborator

Secrus commented Dec 9, 2024

Those issues are not present on the master branch, so I assume they are connected to your changes.

@Minku-Koo
Copy link
Contributor Author

@Secrus I re-upload pull request same changes with #867

@Minku-Koo Minku-Koo closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants