Update location of the custom.py file
#825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <[email protected]>
VascoSch92
reviewed
May 20, 2024
| @@ -166,7 +166,7 @@ The ``locale.py`` file must not be modified. It contains the translations provid | |||
| the CLDR database. | |||
|
|
|||
| The ``custom.py`` file is the one you want to modify. It contains the data needed | |||
| by Pendulum that are not provided by the CLDR database. You can take the `en <https://github.com/sdispater/pendulum/tree/master/pendulum/locales/en/custom.py>`_ | |||
| by Pendulum that are not provided by the CLDR database. You can take the `en <https://github.com/sdispater/pendulum/tree/master/src/pendulum/locales/en/custom.py>`_ | |||
There was a problem hiding this comment.
Suggested change
| by Pendulum that are not provided by the CLDR database. You can take the `en <https://github.com/sdispater/pendulum/tree/master/src/pendulum/locales/en/custom.py>`_ | |
| by Pendulum that is not provided by the CLDR database. You can take the `en <https://github.com/sdispater/pendulum/tree/master/src/pendulum/locales/en/custom.py>`_ |
There was a problem hiding this comment.
data is plural; are is the correct verb tense.
|
@VascoSch92 - Based on @voidnolog, what do you prefer? |
@voidnologo is right ;-) |
|
@VascoSch92 in this case, please merge changes when possible. |
|
@emmanuel-ferdman i cannot ;) not an administrator here |
|
@Secrus @sdispater Could you please review and merge this PR? |
Secrus
approved these changes
Oct 29, 2024
CodSpeed Performance ReportMerging #825 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
PR Summary
PR #755 moved the location of the
custom.pyfile. This PR adjusts sources to changes.