-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dmypy support via mypy.api.run_dmypy #1
Conversation
@Richardk2n Friendly ping, I'm not sure if you'd like to fold this in along with #2 but it'd be great to include this if possible. I've fixed up the lingering 3.6 syntax failures. |
Referenced in tomv564#51 |
Once #2 is successfully merged (probably in a few minutes), I will look at this (maybe ask some questions) and then probably merge it as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor issues with string interpolation in logging statements and references to python-language-server instead of python-lsp-server.
@asford Should the daemon be closed for example atexit ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates from review.
I don't think the daemon should be closed, as the daemon can persist expensive cached state between editor sessions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f-string updates
palantir/python-language-server#391 Update plugin flow for non-live-mode dmypy invocation via run_dmypy. Minor fix to update detect `.mypy.ini` as well as `mypy.ini`.
Roger, thanks for the through review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I've noticed that using |
mypy also creates a |
I guess I'm used to From the documentation it looks like it's in fact a temporary file that could be ignored but in that case can't we actually define its location to be But in the worse case, git-ignoring |
palantir/python-language-server#391
Update plugin flow for non-live-mode dmypy invocation via
mypy.api.run_dmypy
.Minor fix to update detect
.mypy.ini
as well asmypy.ini
:https://mypy.readthedocs.io/en/stable/config_file.html