Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navbar dropdown toggle for touchscreens using Safari #1273

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

hedyhli
Copy link
Member

@hedyhli hedyhli commented Mar 27, 2024

Fixes #1208.

All the discussion/details regarding implementation can be found in the linked issue.

It'd be best if you have a target device to test it on, but if not, take a look at this stackoverflow answer.

@hedyhli hedyhli added type: bug Something isn't working area: frontend Related to site content and user interaction s: needs review Author is waiting for someone to review and approve labels Mar 27, 2024
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit 422c5fe
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/66039f80b074f20008a1a2e8
😎 Deploy Preview https://deploy-preview-1273--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 422c5fe on fix/safari-touch-toggle-dropdown
into f3f78ed on main.

@jchristgit jchristgit merged commit 4eba052 into main Mar 29, 2024
11 of 12 checks passed
@jchristgit jchristgit deleted the fix/safari-touch-toggle-dropdown branch March 29, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to site content and user interaction s: needs review Author is waiting for someone to review and approve type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to toggle "More" on navbar without long-press on Safari
3 participants