Use proper logos and better positioning in the footers #1268
Conversation
- Switch from CSS filtering to actual logos with white text. - Adjust positioning to align all text in the logos with baseline and ensure they're center aligned with a uniform side spacing.
hedyhli
added
area: frontend
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There doesn't seem to be a way (say relative units, etc) to make it look good on both worlds. We'll prioritize windows for now since most of our users come from there.
|
It should be alright in both windows and android now. On iOS, it's pretty misaligned vertically if I zoom in, but it's probably somewhat subtle otherwise. Since this isn't such a major issue (I've made sure no part of the image is cut off on all platforms) we'll just make sure it looks good for the majority of our users for now, as lemon suggested in the linked discussion. Considering that this is web dev, I wonder if a cross-platform solution even exists. Descenders in Django and Netcup which is what caused the issue can't really be fixed without hardcoding the vertical offsets, but I've cropped the linode icon and switched to the text-only Bulma logo (both of which has no descenders) so it will show up aligned on all platforms. |
This ensures no vertical positioning for this image is required because the image is cropped to fit the text.
Don't mind me, just being a little overly excited with this one as this is my most ingenius idea yet!
|
Of course, wookie, I hacked into your computer to test it! ;P But yes, since they're fairly small logos in the footer I don't think the offsets on iOS are that noticeable. We could see if anyone complains. |
Closes #662, and as part of it, also closes #458.
Relevant
#dev-contribdiscussion: https://discord.com/channels/267624335836053506/635950537262759947/1220627130644434996Changes
Footer logos and positioning: