Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to add new resources #1226

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Conversation

hedyhli
Copy link
Member

@hedyhli hedyhli commented Feb 7, 2024

Part of #497.

Added:

  • A link to open an issue in the meta repo, with appropriate issue template, for viewers.
    • This is placed under the filter box when the filter box is on the left column (for tablets+)
    • For mobile, it is under the last resource item, because it doesn't make sense for this information to be presented to the user before they even see the list of resources.
    • Bulma classes clarification: https://bulma.io/documentation/helpers/visibility-helpers/#hide
  • Docs in the readme with guidelines for the YAML files, for contributors.

Third point from the issue:

The review process for a new resource. Who reviews and approves these suggestions?

Is this necessary? Is there a review process we should document here?

I'll leave this for @swfarnsworth. [Discord message ref (staff chat)].

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit 4099c02
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/65eda60c840a4d00089ef1f7
😎 Deploy Preview https://deploy-preview-1226--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hedyhli hedyhli added the area: docs Adds or updates documentation label Feb 7, 2024
@coveralls
Copy link

coveralls commented Feb 7, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 4099c02 on docs/suggest-resources
into 721aabe on main.

@hedyhli hedyhli added the s: needs review Author is waiting for someone to review and approve label Feb 7, 2024
@Xithrius Xithrius requested a review from fisher60 February 9, 2024 06:44
@jchristgit jchristgit self-assigned this Mar 2, 2024
@jchristgit jchristgit self-requested a review March 2, 2024 10:27
Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay with reviews, this looks good to me!

@jchristgit jchristgit requested a review from Xithrius March 2, 2024 10:28
@ChrisLovering ChrisLovering merged commit e39cbf3 into main Mar 10, 2024
4 checks passed
@ChrisLovering ChrisLovering deleted the docs/suggest-resources branch March 10, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Adds or updates documentation s: needs review Author is waiting for someone to review and approve
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants