This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
Docker Based Tests #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #6 This commit changes the Travic CI pipeline to run ansible in a docker container and additionally tests the deployment tasks. Updated README.md to contain new test script
mattrasband
reviewed
May 22, 2017
| @@ -3,7 +3,7 @@ | |||
| hosts: testserver | |||
| roles: | |||
| - role: setup-server | |||
| tags: setup-server | |||
There was a problem hiding this comment.
I like that you removed these, since currently they don't really add any value
mattrasband
reviewed
May 22, 2017
| @@ -0,0 +1,11 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
I wonder if we should add a bin directory, since my guess is over time we will have a number of scripts assembled like this. Though not an issue for now.
There was a problem hiding this comment.
This is definitely a good idea, or migrating the test execution to a custom setup.py command
mattrasband
reviewed
May 22, 2017
| @@ -8,7 +8,7 @@ | |||
| - Restart pythondev | |||
| when: systemd_enabled == true | |||
|
|
|||
| - name: Restart pythondev | |||
| - name: Restart pythondev-site | |||
There was a problem hiding this comment.
Looks like you may have missed other references to this name, such as on line 8 of this same file. Either that or we just have two redundant tasks here (which is probably the case)
mattrasband
reviewed
May 22, 2017
| @@ -1,2 +1,5 @@ | |||
| [sirbot] | |||
| pythondev-01 | |||
|
|
|||
| [test] | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6
This commit changes the Travic CI pipeline to run ansible in a docker container and additionally tests the deployment tasks.
Updated README.md to contain new test script