This repository has been archived by the owner on Jan 24, 2018. It is now read-only.
extract nginx role in line with #39 #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrasband
commented
Jul 20, 2017
| retry_files_enabled = False | ||
| roles_path = ./roles/ |
ovv
reviewed
Jul 20, 2017
|
|
||
| ## Testing | ||
|
|
||
| Tests are run via Travis CI's `.travis.yml`. Unit tests can be manually via docker with: | ||
|
|
||
| $ docker run -t -i -v ${PWD}:/data geerlingguy/docker-ubuntu1604-ansible /data/run_tests.sh | ||
| ```bash | ||
| $ docker run -t -i -v ${PWD}:/data geerlingguy/docker-ubuntu1604-ansible /data/run_tests.sh |
There was a problem hiding this comment.
I think we should also provide the command for testing on debian 9
There was a problem hiding this comment.
Oh, this is just a reformatting of what is already there to be explicit with the language. As the roles break out of here, I think this loses value and each role is responsible for its own testing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with the idea of #39 - this is the first extracted role,
nginx. A fresh server would be best to set up since this now names the sites (dict key value), instead of just grabbing the first domain name.Note the new readme additions!