Combine bugfix #153
Merged
Combine bugfix #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure fill value evaluation works for NaN.
Added a function to evaluate fill values for normal and special values (e.g., NaN and Inf).
Ensure mock downloads test for both versions of potential F10.7 prelim file names.
Partial fix for combine_kp bugs.
Fixed boolean True/False swap.
Fixed the boolean swap logic and removed debug statements.
Fixed the `is_fill_val` implementation for string types.
Fixed under-indented line.
Added unit test for `is_fill_val`.
Added summary of changes to the changelog.
Moved up the time evaluation for the forecast F10.7 data in the combine function. Also removed a duplicate definition of a date range variable.
aburrell
commented
Oct 2, 2024
Comment on lines
-270
to
-271
| date_range = pds.date_range(start=start, end=end_date, freq=freq) | ||
|
|
There was a problem hiding this comment.
This was already identically defined on line 265
|
Tests are failing because:
|
jklenzing
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses bugs found when fixing an issue in the operational workflow.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran locally with operational code and added unit test.
Test Configuration
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release