Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: support for pysat behaviour changes #132

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Oct 24, 2023

Description

Addresses #117 and adds TODO statements for issue #131 to reduce user warnings after the next pysat release.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran unit tests locally

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.9
  • Any details about your local setup that are relevant: develop branch of pysat

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Updated `use_header` use to reduce user warnings after the next pysat release.
Updated the load kwargs and the temporary try/except loop to reflect changes in pysat.
Removed extra whitespace.
Added a summary of the changes in this pull request to the changelog.
@aburrell aburrell added this to the 0.1.0 Release milestone Oct 24, 2023
@aburrell aburrell requested a review from jklenzing October 24, 2023 16:33
Added the package logo to the documentation and changed the table of contents to show a pared down index.
@aburrell aburrell merged commit 1a44957 into develop Oct 24, 2023
18 checks passed
@aburrell aburrell deleted the maint_try_except_data branch October 24, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants