Develop lisird fix #128
Merged
Develop lisird fix #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the test date for the daily F10.7 data to work with the new pysat padding unit tests.
Updated LISIRD downloads to match the new behaviour when no data is available. Will also work with prior behaviour, should they decide to switch back.
Added a missing line to a test docstring.
Added a summary of the changes to the changelog.
Fixed formatting and grammar in the issue templates.
Fixed formatting in the PR template.
Updated the CI tests to use pyproject.toml.
Updated the .gitignore comments.
Added the required configuration file for RTD.
Added FAQ section to the code of conduct.
Updated the style, links, and wording in the contributing guidelines.
Updated the document configuration file.
Update the manifest to reflect the package changes.
Replaced the setup.py with the new standard, a pyproject.toml file.
Get the version data from the pyproject.toml.
Remove unnecessary text file.
Cycled pysat minimum version, removed alpha note for the next release and fixed bug in the example.
Removed data from setup.cfg that is now stored in the pyproject.toml.
Update the package limits in the test requirements.
Added a summary of changes to the log.
Updated the installation instructions to use the pyproject.toml file.
|
Merge #129 first to get the documentation test to work and test this fix on the new CI configuration. |
Added missing key to install dependencies.
Ensured there is always a space after a keyword.
Replace placeholder with real package name.
Re-added a variable that was accidentally removed.
Import name is different from the package name.
Fixed resource usage by specifying full path with os.path.join.
Fixed the path call to use the resource library correctly.
Added a missing requirement for the operational install.
Template update for bugfix
jklenzing
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #126 for the develop branch. If a fix is needed for main, this can be done with the
main_f107_lisird_fixbranch.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran unit tests, which now all pass.
Test Configuration
Checklist:
develop(notmain) branchCHANGELOG.md, summarizing the changesIf this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release