Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LGL: Update controlled information statement for clarity and accuracy #63

Open
wants to merge 11 commits into
base: rc0_0_5
Choose a base branch
from

Conversation

rstoneback
Copy link
Collaborator

Description

Addresses # (issue)

Updates controlled information statement for clarity and accuracy and to maintain pysat's legal rights over pysat code.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Only comments updated, no additional testing required.

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@rstoneback rstoneback changed the base branch from develop to rc0_0_5 December 18, 2024 23:30
@rstoneback
Copy link
Collaborator Author

So the error that is popping up appears to be outside anything we are doing:

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.10.15/x64/lib/python3.10/site-packages/tomli/_parser.py", line 716, in parse_value
    return parse_inline_table(src, pos, parse_float, nest_lvl + 1)
TypeError: TomlDecoder.loads.<locals>._parse_inline_table() takes 3 positional arguments but 4 were given

@rstoneback
Copy link
Collaborator Author

extras_require issue now tracked in #64

@rstoneback rstoneback requested a review from aburrell December 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant