Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize infrastructure #45

Merged
merged 24 commits into from
Oct 25, 2023
Merged

Modernize infrastructure #45

merged 24 commits into from
Oct 25, 2023

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Oct 14, 2023

This PR:

  • resolves migrate docs to GH Pages? #42
  • resolves Modernize infrastructure  #43
  • resolves add a codecov config file #44
    • swaps out setup.* for pyproject.toml
    • adopt setuptools_scm
    • ruff lints more strictly
    • adds pre-commit-config
    • cleans and reruns notebooks
    • remove old/superfluous files
      • all setup*.* (and related) files
      • all docs/{build,generated}* files (this accounts for the huge file diff)
    • adopts pytest over unittest
    • revamps docs & ensure docs build locally (and beautifully)
    • etc.

@martinfleis this isn't complete, but how's looking so far? Some questions/comments:

  • Do we want to address migrate docs to GH Pages? #42 in this PR and add an action for it? And if so, shall we remove the RTD yaml?
  • Should I put a release action in here even though we won't be able to use it yet?
  • Anything obvious I am missing here?

@jGaboardi jGaboardi requested a review from martinfleis October 14, 2023 01:33
@jGaboardi jGaboardi self-assigned this Oct 14, 2023
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #45 (593c7e6) into main (7939ea9) will increase coverage by 1.9%.
The diff coverage is 83.8%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #45     +/-   ##
=======================================
+ Coverage   69.8%   71.7%   +1.9%     
=======================================
  Files          9       8      -1     
  Lines        999     760    -239     
=======================================
- Hits         697     545    -152     
+ Misses       302     215     -87     
Files Coverage Δ
spglm/__init__.py 100.0% <100.0%> (ø)
spglm/family.py 84.3% <100.0%> (+2.1%) ⬆️
spglm/glm.py 97.0% <100.0%> (ø)
spglm/iwls.py 83.6% <100.0%> (+1.2%) ⬆️
spglm/varfuncs.py 77.4% <100.0%> (ø)
spglm/base.py 46.2% <66.7%> (+0.8%) ⬆️
spglm/links.py 63.3% <81.0%> (ø)
spglm/utils.py 48.1% <50.0%> (+20.2%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

spglm/base.py Show resolved Hide resolved
@jGaboardi
Copy link
Member Author

@martinfleis I think this PR is ready for review now. I have added the docs and release workflows, event though the release will not work until we get access to PyPI/spglm.

@jGaboardi jGaboardi requested a review from martinfleis October 15, 2023 17:38
@jGaboardi jGaboardi changed the title draft: Modernize infrastructure Modernize infrastructure Oct 15, 2023
@martinfleis
Copy link
Member

readthedocs.yml can go, so we don't build the docs twice, now that we have the action. Otherwise looks good, though it is a bit pain to review this :D.

@jGaboardi
Copy link
Member Author

readthedocs.yml can go, so we don't build the docs twice, now that we have the action. Otherwise looks good, though it is a bit pain to review this :D.

No good deed goes unpunished. 🤣

@jGaboardi
Copy link
Member Author

@martinfleis And it's been a long time since I've set up the GH-Pages stuff. Not sure I did it correctly... In Setting/Pages I simply changed the branch to main/root, but that doesn't feel right...

@martinfleis
Copy link
Member

I've never done it (momepy still runs on RTD and its own domain) but you'll need to point it to gh-pages/root. But gh-pages branch does not exist yet. Not sure if the action will create it or it needs to be created and populated manually first.

@jGaboardi
Copy link
Member Author

Perhaps @knaaptime can advise? But also, once this is reviewed and merged I can simply do some trial and error v1.1.0rcXX tag & releases (which will fail) to get the doc build sorted.

@knaaptime
Copy link
Member

pretty sure the action will create the branch if necessary

@martinfleis
Copy link
Member

@jGaboardi it seems that you should have all the rights you need to setup the publishing action with a token, right?

@jGaboardi
Copy link
Member Author

@jGaboardi it seems that you should have all the rights you need to setup the publishing action with a token, right?

Yep, I just set that up right now. So once this PR is reviewed and merged we can give v1.1.0rc1 a go.

@martinfleis
Copy link
Member

@jGaboardi What is the status here?

@jGaboardi
Copy link
Member Author

Waiting for a review.

.pre-commit-config.yaml Outdated Show resolved Hide resolved
Co-authored-by: Martin Fleischmann <[email protected]>
@jGaboardi jGaboardi merged commit 8cbcf35 into pysal:main Oct 25, 2023
8 checks passed
@jGaboardi jGaboardi deleted the modernize_infra branch October 25, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a codecov config file Modernize infrastructure migrate docs to GH Pages?
3 participants