Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry building PDF from readthedocs.yml #455

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Jan 8, 2023

This PR reverts 3dd803b. We may also want to try update the Python version with readthedocs.yml.

xref #294

@jGaboardi jGaboardi self-assigned this Jan 8, 2023
@jGaboardi jGaboardi requested a review from martinfleis January 8, 2023 20:32
@jGaboardi
Copy link
Member Author

Failures are not due to this PR; see #456 & #457.

@martinfleis
Copy link
Member

How do we know it is okay now? This https://readthedocs.org/projects/momepy/builds/19107913/ doesn't seem to build a PDF. Maybe that is enabled only on main?

@jGaboardi
Copy link
Member Author

jGaboardi commented Jan 8, 2023

I was about to ask you that question... 😆

Maybe that is enabled only on main?

Let's try a merge to find out?

@martinfleis martinfleis merged commit 84db796 into pysal:main Jan 9, 2023
@martinfleis
Copy link
Member

had to enable it in RTD

@jGaboardi
Copy link
Member Author

Although it was triggered, the build failed.

@jGaboardi jGaboardi deleted the build_pdf branch January 9, 2023 14:28
jGaboardi added a commit that referenced this pull request Jan 9, 2023
martinfleis pushed a commit that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants