ENH: expose scatterplot on bivariate Moran stats #358
+86
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
- Coverage 81.7% 81.4% -0.2%
=======================================
Files 24 24
Lines 3396 3406 +10
=======================================
Hits 2773 2773
- Misses 623 633 +10
|
|
Do we need tests for this functionality? |
|
Most of it is tested using the univariate. Technically we should but I am not sure it is worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes scatterplot plotting on BV versions of Moran as well, using the same implementation. Together with #357 this concludes move of the individual plotting functions from
splot. Remaining stuff is are just subplots which I am not sure is wort moving.